Add search for modules #257
Merged
+81
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0michalsokolowski0
approved these changes
Sep 13, 2024
mbialon
reviewed
Sep 13, 2024
| var modules []module | ||
|
|
||
| for { | ||
| pageSize := 50 |
There was a problem hiding this comment.
Suggested change
| pageSize := 50 | |
| pageSize := maxSearchModulesPageSize |
| func listModulesTable(ctx *cli.Context) error { | ||
| func getSearchModules(cliCtx *cli.Context, cursor string, limit int) (searchModules, error) { | ||
| if limit <= 0 || limit > maxSearchModulesPageSize { | ||
| return searchModules{}, errors.New("limit must be between 1 and 50") |
There was a problem hiding this comment.
This error message can get out of sync with the values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #247