Further improve repository string detection for open command #264
+46
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyhager
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further improves upon the existing repo name detection here: #233
While the current code works for
https://andgit@, it does not work for those who use assh://git@prefix:example:
The gh cli repo already has existing logic for a handful of possible git urls, so this PR includes a dependency update so the
/cli/gitpackage can be imported and used for repo detection.Both
spacectlandcliare MIT-licensed, so there (hopefully) won't be licensing concernshttps://github.com/spacelift-io/spacectl/blob/main/LICENSE
https://github.com/cli/cli/blob/v2.57.0/LICENSE