Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds 'update PR comment' routes to allowlist #82

Conversation

silviutanasa
Copy link
Contributor

@silviutanasa silviutanasa commented Sep 24, 2024

Description of the change

As part of CU-8694k6wnq (Allow notification policy to update PR comment in-place) new endpoints were added for the VCSs, in order to update the PR comments.

This change was meant to add support for Bitbucket Data Center, but because it was not known at that time that the new VCS routes must be added to the allowlist, it also add the missing routes for the Azure DevOps and Gitlab. Github enterprise doesn't need to be updated as it uses GraphQL and the main route is already added to the allowlist.

The allowlist NoMatch error message was changed in order to be clearer and avoid being confused with the gock package errors when testing (when trying to mock a HTTP request in tests, if the request URL was not in the allowlist, the test use to failed with "no match for request" which was easily confused to "the request was not properly mocked")

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality not to work as expected);
  • Other (miscellaneous, GitHub workflow changes, changes to the PR template);

Checklists

Development

  • Lint rules pass locally;
  • All tests related to the changed code pass in development;

Code review

  • This pull request has a descriptive title and sufficient context for a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer a draft;

Deployment

  • Selected merge strategy is squash merge;
  • Changes have been reviewed by at least one other engineer;

@Clickup-user
Copy link

@silviutanasa silviutanasa marked this pull request as ready for review September 24, 2024 07:57
@silviutanasa silviutanasa self-assigned this Sep 24, 2024
@silviutanasa silviutanasa merged commit f068a59 into main Sep 24, 2024
4 checks passed
@silviutanasa silviutanasa deleted the cu-8695nnat3-add-pr-ntf-update-comment-support-for-bitbucket-dc branch September 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants