imviz-round-1.5 (astrowidgets + Glupyter) #445
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like #428 but swaps out Ginga with Glupyter. Sketchy dummy classes are gone. I was unable to test the CLI locally due to voila-dashboards/voila#843 (long story... see #448 )
Special software requirements:
glue-jupyter
bqplot-image-gl
might work though I used dev version tooastrowidgets
from EXP: glupyter implementation on abstract class astropy/astrowidgets#131 that builds on Initial implementation of abstract class astropy/astrowidgets#126 (until these are merged, the CI here won't pass)Known issues:
astrowidgets
API to load data, it clears the previous data collection first, otherwise the API doesn't work properly; see "Known issues" at EXP: glupyter implementation on abstract class astropy/astrowidgets#131 -- Should not be an issue unless we want to load multiple datasets into the same viewer?TODO
specviz/helpers.py
but is it the the mixin or the API extension in final subclass?