updates from review

spacetelescope · Feb 20, 2025 · 1f895c4 · 1f895c4
1 parent c5a693e
commit 1f895c4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/stdatamodels/jwst/datamodels/schemas/specwcs_miri_lrs.schema.yaml b/src/stdatamodels/jwst/datamodels/schemas/specwcs_miri_lrs.schema.yaml
@@ -67,22 +67,22 @@ allOf:
         x_ref:
           type: number
           title: x coord of ref position of MIRIM_SLIT
-          default: pixels
+          units: pixels
           fits_keyword: IMX
         y_ref:
           type: number
           title: y coord of ref position of MIRIM_SLIT
-          default: pixels
+          units: pixels
           fits_keyword: IMY
         x_ref_slitless:
           type: number
           title: x coord of ref position of MIRIM_SLITLESS
-          default: pixels
+          units: pixels
           fits_keyword: IMXSLTL
         y_ref_slitless:
           type: number
           title: y coord of ref position of MIRIM_SLITLESS
-          default: pixels
+          units: pixels
           fits_keyword: IMYSLTL
         v2_vert1:
           type: number

diff --git a/src/stdatamodels/jwst/datamodels/tests/test_specwcs_mirilrs_datamodel.py b/src/stdatamodels/jwst/datamodels/tests/test_specwcs_mirilrs_datamodel.py
@@ -41,6 +41,10 @@ def test_miri_lrs_specwcs():
     )
 
     model = datamodels.MiriLRSSpecwcsModel(x_ref=430, y_ref=400, wavetable=wavetable)
+    model.meta.description = "MIRI LRS SPECWCS reference file"
+    model.meta.author = "Jane Morrison"
+    model.meta.pedigree = "FLIGHT"
+    model.meta.useafter = "2022-05-01T00:00:00"
     assert model.meta.instrument.name == "MIRI"
     assert model.meta.instrument.detector == "MIRIMAGE"
     assert model.meta.reftype == "specwcs"
@@ -57,3 +61,4 @@ def test_miri_lrs_specwcs():
     assert model.meta.v3_vert2 is None
     assert model.meta.v3_vert3 is None
     assert model.meta.v3_vert4 is None
+    model.validate()
diff --git a/src/stdatamodels/jwst/datamodels/wcs_ref_models.py b/src/stdatamodels/jwst/datamodels/wcs_ref_models.py
@@ -489,7 +489,7 @@ def __init__(
     def populate_meta(self):
         self.meta.instrument.name = "MIRI"
         self.meta.instrument.detector = "MIRIMAGE"
-        self.meta.reftype = self.reftype
+        self.meta.reftype = self.reftype.lower()
         self.meta.instrument.filter = "P750L"
 
     def validate(self):