Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate get_fileext #363

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Nov 15, 2024

As noted in #16 DataModel.get_fileext is unused.

This PR deprecates it for removal in an upcoming release.

Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/11863222622
and the logs do not contain the warning added in this PR (confirming no use in jwst).

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review November 15, 2024 21:20
@braingram braingram requested a review from a team as a code owner November 15, 2024 21:20
@braingram braingram requested a review from emolter November 15, 2024 22:18
Copy link
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (f66a0e4) to head (a70d4ea).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files         115      114       -1     
  Lines        5928     5917      -11     
==========================================
- Hits         4005     3997       -8     
+ Misses       1923     1920       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram enabled auto-merge (squash) November 20, 2024 19:07
@braingram braingram merged commit ab0cba5 into spacetelescope:main Nov 20, 2024
22 checks passed
@braingram braingram deleted the rm_get_fileext branch November 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants