Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3710: add channel to apcorr table for MIRI LRS and imaging #374

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Jan 7, 2025

Resolves JP-3710

Closes spacetelescope/jwst#8715

This PR adds CHANNEL to the MIRI LRS and imaging apcorr datamodels. This will likely always be set to N/A, but its inclusion avoids CRDS errors since CRDS lumps these modes in with MIRI MRS, for which CHANNEL is needed.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (788f7bd) to head (470e0b0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #374       +/-   ##
===========================================
+ Coverage   67.59%   78.20%   +10.60%     
===========================================
  Files         115      115               
  Lines        5932     5135      -797     
===========================================
+ Hits         4010     4016        +6     
+ Misses       1922     1119      -803     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review January 7, 2025 20:03
@emolter emolter requested a review from a team as a code owner January 7, 2025 20:03
@emolter
Copy link
Contributor Author

emolter commented Jan 7, 2025

started jwst regtests here https://github.com/spacetelescope/RegressionTests/actions/runs/12658462594

edit: all passing after re-run

@emolter emolter marked this pull request as draft January 7, 2025 20:33
@emolter emolter closed this Jan 7, 2025
@emolter emolter reopened this Jan 7, 2025
@emolter emolter requested a review from braingram January 8, 2025 14:25
@emolter emolter marked this pull request as ready for review January 8, 2025 14:27
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emolter emolter enabled auto-merge (squash) January 8, 2025 14:29
@emolter emolter merged commit 70de57f into spacetelescope:main Jan 8, 2025
22 checks passed
@emolter emolter deleted the JP-3710 branch January 8, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update apcorr datamodels to allow CHANNEL keyword for MIRI
2 participants