Validate dimension when instantiating datamodel from shape

changes/395.bugfix.rst

@@ -0,0 +1 @@
+Validate dimension against schema when instantiating datamodel from array shape

src/stdatamodels/jwst/datamodels/tests/test_models.py

@@ -142,7 +142,7 @@ class _NonstandardPrimaryArrayModel(JwstDataModel):
         def get_primary_array_name(self):
             return "wavelength"
 
-    m = _NonstandardPrimaryArrayModel((10,))
+    m = _NonstandardPrimaryArrayModel((10, 10))
     assert "wavelength" in list(m.keys())
     assert m.wavelength.sum() == 0
 

src/stdatamodels/properties.py

@@ -180,6 +180,10 @@ def _make_default_array(attr, schema, ctx):
 
     if attr == primary_array_name:
         if ctx.shape is not None:
+            # Ensure that input shape matches schema ndim
+            if (ndim is not None) and (len(ctx.shape) != ndim):
+                msg = f"Array has wrong number of dimensions. Expected {ndim}, got {len(ctx.shape)}"
+                raise ValueError(msg)
             shape = ctx.shape
         elif ndim is not None:
             shape = tuple([0] * ndim)

tests/test_models.py

@@ -100,6 +100,11 @@ def test_init_with_array2():
             dm.data  # noqa: B018
 
 
+def test_init_invalid_shape():
+    with pytest.raises(ValueError):
+        BasicModel((50, 50, 50))
+
+
 def test_set_array():
     with pytest.raises(ValueError):
         with BasicModel() as dm: