Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dqflag functions #409

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 21, 2025

Closes #408

Requires: spacetelescope/jwst#9212

This PR cleans up stdatamodels.dqflags removing the submodule as all functions are unused. Removing dqflags removes the last use of basic_utils and basic_utils also removed in this PR. Finally the removed functions are also removed from stdatamodels.jwst.dqflags.__all__.

Regtests with spacetelescope/jwst#9212
https://github.com/spacetelescope/RegressionTests/actions/runs/13465093241

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (4e83608) to head (6b2f08f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   78.16%   78.35%   +0.19%     
==========================================
  Files         115      113       -2     
  Lines        5144     5134      -10     
==========================================
+ Hits         4021     4023       +2     
+ Misses       1123     1111      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 24, 2025 16:06
@braingram braingram requested a review from a team as a code owner February 24, 2025 16:06
Copy link
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram
Copy link
Collaborator Author

braingram commented Feb 24, 2025

LGTM

Thanks! To be extra careful I started a fresh regtest run (with jwst main and this PR):
https://github.com/spacetelescope/RegressionTests/actions/runs/13503031007

@braingram braingram merged commit deb4b67 into spacetelescope:main Feb 24, 2025
19 checks passed
@braingram braingram deleted the dqflags_cleanup branch February 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup dqflags
2 participants