Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove OutlierPars model #421

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 24, 2025

Closes #410

Removes the unused OutlierPars model.

Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/13506773303

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (4e83608) to head (8612199).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   78.16%   78.35%   +0.18%     
==========================================
  Files         115      110       -5     
  Lines        5144     5110      -34     
==========================================
- Hits         4021     4004      -17     
+ Misses       1123     1106      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 24, 2025 21:29
@braingram braingram requested a review from a team as a code owner February 24, 2025 21:29
@braingram braingram merged commit 26c9f0f into spacetelescope:main Feb 24, 2025
19 checks passed
@braingram braingram deleted the remove_outlierpars branch February 24, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed unused OutlierPars model and schema
2 participants