Fix overflow #8
Open
Fix overflow #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calibration variables _cal_vi1 and _cal_vj1 were uint16_t, but this led to overflow on my screen, making the touch x-position jump from around 100 to 56,000 in the lower 25% of the screen. Changing these variables to int32_t fixes this overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a weird issue with my TJCTM24028-SPI (cheap eBay touch screen + TFT) and this library. When touching the lower 25% of the screen, the XPTPaint program worked ok, but when going into the top 75% the lines jumped off the screen and were not where my finger was touching. I tracked down the cause (or, at least, the change that fixes this) to the calibration variables
_cal_vi1and_cal_vj1. These were previously set touint16_t, but are used in a calibration operation involvingint32_tnumbers, potentially leading to overflow (as in my case). Changing these variables toint32_tfixes this overflow, and solves the problem on my screen with discontinuities.