Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on job title click inside Admin Report #794

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix crash on job title click inside Admin Report #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0467bfd
Fix crash on job title click inside Admin Report
Rayavishek Mar 6, 2017
1bb4b50
Merge pull request #793 from Rayavishek/develop
Rayavishek Mar 6, 2017
a14a67f
Application date incorrect + Auto confirm interviews from round 2 onw…
Rayavishek Mar 6, 2017
b5aea1b
Merge pull request #795 from Rayavishek/develop
Rayavishek Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/controllers/businessLogic/JobWorkflow/JobPostWorkflowEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3145,10 +3145,13 @@ public static Integer updateFeedback(AddFeedbackRequest addFeedbackRequest, int

interviewRound = jobPostWorkflowNew.getInterviewRound() + 1;

/*
int jwfStatus = jobPostWorkflowCurrent.getJobPost().getReviewApplication()
== ServerConstants.REVIEW_APPLICATION_AUTO ?
ServerConstants.JWF_STATUS_INTERVIEW_CONFIRMED : ServerConstants.JWF_STATUS_INTERVIEW_SCHEDULED;

*/
// Always auto-confirm interviews from Round 2 onwards
int jwfStatus = ServerConstants.JWF_STATUS_INTERVIEW_CONFIRMED;
saveNewJobPostWorkflow(jobPostWorkflowNew, jobPostWorkflowNew.getStatus().getStatusId(),
jwfStatus, slotId,
interviewDate, channel, interviewRound, interviewRecruiter,
Expand Down
2 changes: 1 addition & 1 deletion public/recruiter/rmp/js/p_recruiter_job_post_report_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var zapp = (function () {

returned_data.push({
'jobTitle': function () {
return '<div class="mLabel" style="width:100%"><a href="/recruiter/jobPostTrack/'+response.jobPostId + '">'+response.jobTitle+'</div>';
return '<div class="mLabel" style="width:100%"><a href="/recruiter/jobPostTrack/'+response.jobPostId + '/i">'+response.jobTitle+'</div>';
},
'jobPostedOn': response.jobPostedOn,
'fulfillment': response.percentageFulfillment,
Expand Down
10 changes: 8 additions & 2 deletions public/recruiter/rmp/js/recruiter_job_post_track.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,10 @@ function tabChange2() {
returned_data.push({
'candidateId' : workflowObj.candidate.candidateId,
'date' : function() {
var postedOn = new Date(workflowObj.extraData.creationTimestamp);
if(workflowObj.appliedOn) {
var postedOn = new Date(workflowObj.appliedOn);
}
else var postedOn = new Date(workflowObj.extraData.creationTimestamp);
var dateVal = ('0' + postedOn.getDate()).slice(-2) + '-' + getMonthVal((postedOn.getMonth()+1)) + '-' + postedOn.getFullYear()
return '<div class="mLabel" style="width:100%" >'+ dateVal + '</div>'
},
Expand Down Expand Up @@ -489,7 +492,10 @@ function tabChange3() {
returned_data.push({
'candidateId' : workflowObj.candidate.candidateId,
'date' : function() {
var postedOn = new Date(workflowObj.extraData.creationTimestamp);
if(workflowObj.appliedOn) {
var postedOn = new Date(workflowObj.appliedOn);
}
else var postedOn = new Date(workflowObj.extraData.creationTimestamp);
var dateVal = ('0' + postedOn.getDate()).slice(-2) + '-' + getMonthVal((postedOn.getMonth()+1)) + '-' + postedOn.getFullYear()
return '<div class="mLabel" style="width:100%" >'+ dateVal + '</div>'
},
Expand Down