feat: Create notification FastAPI #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyukychang
reviewed
Apr 29, 2024
Comment on lines
37
to
39
| related_comment_id=notification.related_comment_id, | ||
| is_read=False | ||
| ) |
There was a problem hiding this comment.
is_read 값은 왜 항상 false 인가요?
Comment on lines
14
to
16
| queryset = Notification.objects.filter( | ||
| notification_read_log_set__read_by=self.request.user, | ||
| ).select_related( |
Comment on lines
42
to
44
| notifications = self.get_all_notifications() | ||
| NotificationReadLog.objects.filter(notification__in=notifications, read_by=self.request.user).update(is_read=True) | ||
|
|
There was a problem hiding this comment.
notification과 notificationReadLog랑은 무슨 차이가 있나요??
Qndndn
force-pushed
the
fastapi/notification
branch
from
3f00b35
to
c8b7d65
Compare
added 2 commits
May 2, 2024 13:26
hyukychang
requested changes
May 17, 2024
Comment on lines
24
to
30
| return [ | ||
| notification | ||
| for notification in notifications | ||
| if NotificationReadLog.objects.filter( | ||
| notification=notification, read_by=user_id, is_read=False | ||
| ).exists() | ||
| ] |
There was a problem hiding this comment.
요거 N+1 쿼리일 가능성이 높아 보이는데 시간 나면 리팩토링 하거나 TODO 체크해주세요 👍
Comment on lines
59
to
63
| return "실명" | ||
| elif article.name_type == NameType.REGULAR: | ||
| return "nickname" | ||
| else: | ||
| related_comment = None | ||
| return "익명" |
There was a problem hiding this comment.
"실명", "nickname", "익명" 전부다 constant로 지정해서 사용해주세요!!!!
| return "익명" | ||
|
|
||
| def create_notification(self, comment: Comment) -> None: | ||
| def notify_article_commented(_parent_article: Article, _comment: Comment): |
| if comment.parent_comment: | ||
| parent_comment = comment.parent_comment | ||
| related_comment = parent_comment | ||
| def get_display_name(self, article: Article, profile: int): |
There was a problem hiding this comment.
이거는 외부로 노출(domain 이나 다른 infra layer에서 사용할거 같아 보이는게 아닌)되지 않으면 함수명에 _ 붙여 주세요
| related_comment = None | ||
| return "익명" | ||
|
|
||
| def create_notification(self, comment: Comment) -> None: |
There was a problem hiding this comment.
이거 transaction이 붙어야 할거 같아요 음... 근데 이거는 어려울 수도 있으니까 같이 한번 봐요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create notification FastAPI.v2