Skip to content

Commit

Permalink
fix: lecture detail page translation
Browse files Browse the repository at this point in the history
  • Loading branch information
snaoyam authored and hoosong0235 committed Aug 7, 2023
1 parent cda3cd1 commit 44c4328
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 2 additions & 0 deletions assets/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
"ask_delete_tab": "Do you really want to delete '{}'?",
"my_tab": "My Table",
"tab": "Table {}",
"add_lecture": "Add Lecture",
"remove_lecture": "Remove Lecture",
"dialog": {
"add_lecture": "Add Lecture",
"ask_add_lecture": "There is a lecture with overlapping hours. If added, the previous lecture will be deleted.\nDo you want to add new lecture to the timetable?"
Expand Down
2 changes: 2 additions & 0 deletions assets/translations/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
"ask_delete_tab": "'{}'을(를) 정말 삭제하시겠습니까?",
"my_tab": "내 시간표",
"tab": "시간표 {}",
"add_lecture": "시간표에 추가",
"remove_lecture": "시간표에서 제거",
"dialog": {
"add_lecture": "수업 추가",
"ask_add_lecture": "시간이 겹치는 수업이 있습니다. 추가하시면 해당 수업은 삭제됩니다.\n시간표에 추가하시겠습니까?"
Expand Down
9 changes: 5 additions & 4 deletions lib/pages/lecture_detail_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,8 @@ class LectureDetailPage extends StatelessWidget {
context: context,
barrierDismissible: false,
builder: (context) => AlertDialog(
title: const Text("수업 추가"),
content: const Text(
"시간이 겹치는 수업이 있습니다. 추가하시면 해당 수업은 삭제됩니다.\n시간표에 추가하시겠습니까?"),
title: Text("timetable.dialog.add_lecture".tr()),
content: Text("timetable.dialog.ask_add_lecture".tr()),

Check warning on line 114 in lib/pages/lecture_detail_page.dart

View check run for this annotation

Codecov / codecov/patch

lib/pages/lecture_detail_page.dart#L113-L114

Added lines #L113 - L114 were not covered by tests
actions: [
IconTextButton(
padding: EdgeInsets.all(12),
Expand Down Expand Up @@ -141,7 +140,9 @@ class LectureDetailPage extends StatelessWidget {
);
}
},
text: isAdded ? "시간표에서 제거" : "시간표에 추가",
text: isAdded
? "timetable.remove_lecture".tr()
: "timetable.add_lecture".tr(),

Check warning on line 145 in lib/pages/lecture_detail_page.dart

View check run for this annotation

Codecov / codecov/patch

lib/pages/lecture_detail_page.dart#L144-L145

Added lines #L144 - L145 were not covered by tests
textStyle: const TextStyle(fontSize: 12.0),
icon: isAdded ? Icons.close : Icons.add,
iconSize: 14,
Expand Down

0 comments on commit 44c4328

Please sign in to comment.