Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Button Pressed Effect #118

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Fix Button Pressed Effect #118

merged 6 commits into from
Aug 1, 2023

Conversation

snaoyam
Copy link
Member

@snaoyam snaoyam commented Jul 31, 2023

No description provided.

@snaoyam snaoyam requested a review from sboh1214 July 31, 2023 18:23
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #118 (12d9dbc) into main (8737dba) will increase coverage by 1.18%.
The diff coverage is 44.75%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   26.11%   27.30%   +1.18%     
==========================================
  Files          78       79       +1     
  Lines        4458     4652     +194     
==========================================
+ Hits         1164     1270     +106     
- Misses       3294     3382      +88
Files Changed Coverage Δ
lib/home.dart 0.00% <0.00%> (ø)
lib/pages/course_detail_page.dart 4.71% <0.00%> (+0.02%) ⬆️
lib/pages/lecture_detail_page.dart 4.91% <0.00%> (+0.05%) ⬆️
lib/pages/main_page.dart 0.00% <0.00%> (ø)
lib/pages/timetable_page.dart 3.35% <0.00%> (-0.05%) ⬇️
lib/pages/user_page.dart 0.00% <0.00%> (ø)
lib/providers/course_search_model.dart 1.31% <0.00%> (ø)
lib/providers/lecture_search_model.dart 3.47% <0.00%> (ø)
lib/widgets/custom_header_delegate.dart 0.00% <0.00%> (ø)
lib/widgets/lecture_group_block_row.dart 0.00% <0.00%> (ø)
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sboh1214 sboh1214 added the feat New feature or request label Jul 31, 2023
hoosong0235
hoosong0235 reviewed Aug 1, 2023
View reviewed changes
lib/providers/course_search_model.dart
Copy link
Contributor

@hoosong0235 hoosong0235 Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evenBodyRegular (나중에 제가 수정하려고 댓글 남겨뒀습니다!)

hoosong0235
hoosong0235 reviewed Aug 1, 2023
View reviewed changes
lib/providers/lecture_search_model.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evenBodyRegular

hoosong0235
hoosong0235 reviewed Aug 1, 2023
View reviewed changes
lib/home.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectedFontSize = 14.0?

hoosong0235
hoosong0235 reviewed Aug 1, 2023
View reviewed changes
lib/widgets/lecture_group_block_row.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTLColor.gray0

hoosong0235
hoosong0235 reviewed Aug 1, 2023
View reviewed changes
lib/widgets/review_block.dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"review.like".tr()

sboh1214
sboh1214 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없겠죠...?

@sboh1214 sboh1214 merged commit 32f5ad9 into main Aug 1, 2023
7 of 8 checks passed
@sboh1214 sboh1214 deleted the feat@button branch August 1, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoosong0235 hoosong0235 hoosong0235 left review comments

@sboh1214 sboh1214 sboh1214 approved these changes

Assignees

@snaoyam snaoyam

Labels
feat New feature or request size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snaoyam @sboh1214 @hoosong0235