-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLNavigator and OTLScaffold #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 27.36% 28.73% +1.37%
==========================================
Files 80 79 -1
Lines 4707 4691 -16
==========================================
+ Hits 1288 1348 +60
+ Misses 3419 3343 -76
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snaoyam
force-pushed
the
feat@page-route
branch
from
August 7, 2023 18:11
8d3a0a4
to
e923e48
Compare
sboh1214
force-pushed
the
feat@page-route
branch
from
August 17, 2023 15:19
e923e48
to
eb1715c
Compare
sboh1214
force-pushed
the
feat@page-route
branch
from
August 19, 2023 06:58
eb1715c
to
be266bc
Compare
sboh1214
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩터링 좋습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTLScaffold and OTLLayout
lib/widgets/otl_scaffold.dart
Scaffold
andbuildAppBar()
OTLScaffold
used alongside withOTLLayout
to create PageOTLNavigator
lib/utils/navigator.dart
Navigator
andlib/utils/build_page_route.dart
transition
argument toOTLNavigator.push()
until
argumentif current push history is
[0] rightLeft
->[1] downUp
->[2] rightLeft
->[3] downUp
->[4] downUp
, below code will pop[2]
,[3]
,[4]
rightLeft
transition: Back button appearson tap, all
downUp
orimmediate
pages that was pushed after the lastrightLeft
transition will be popped.downUp
orimmediate
transition: Close button appearson tap, all
rightLeft
pages that was pushed after the lastdownUp
orimmediate
transition will be popped.