#654 광고성 알림 수신 동의 받기 #663
Merged
#654 광고성 알림 수신 동의 받기 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
predict-woo
reviewed
Sep 22, 2023
| @@ -133,11 +142,16 @@ const ModalNotification = ({ | |||
| beforeDepart: value, | |||
| chatting: value, | |||
| notice: value, | |||
| advertisement: value, | |||
| }, | |||
There was a problem hiding this comment.
궁금한게 있는데 이 여러 옵션들이 value하나로 묶여있어도 되는건가요?
| //#region event2023Fall | ||
| if (optionName === "advertisement" && value) | ||
| event2023FallQuestComplete("adPushAgreement"); | ||
| //#endregion | ||
| }, | ||
| [deviceToken] |
There was a problem hiding this comment.
dependency에 event2023FallQuestComplete 추가해야하지 않을까요?
|
|
||
| //#region event2023Fall | ||
| if (value) event2023FallQuestComplete("adPushAgreement"); | ||
| //#endregion | ||
| }, | ||
| [deviceToken] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #654
Images or Screenshots