Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#685 Introduce Storybook and Vite #687

Merged
merged 30 commits into from
Nov 12, 2023
Merged

#685 Introduce Storybook and Vite #687

merged 30 commits into from
Nov 12, 2023

Conversation

predict-woo
Copy link
Member

Summary

It closes #685

Images or Screenshots

Screenshot 2023-10-26 at 21 06 06

@predict-woo predict-woo linked an issue Oct 26, 2023 that may be closed by this pull request
Add Storybook #685
Closed
2 tasks
@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit dda77c4
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/654d01357cd10000089a1fda
😎 Deploy Preview https://deploy-preview-687--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@14KGun 14KGun self-requested a review October 26, 2023 12:20
@predict-woo predict-woo marked this pull request as ready for review October 26, 2023 12:20
@14KGun 14KGun changed the title Storybook 기능 추가하기 #685 Storybook 기능 추가하기 Oct 26, 2023
@14KGun 14KGun linked an issue Oct 27, 2023 that may be closed by this pull request
vite 도입 #643
Closed
2 tasks
@14KGun 14KGun changed the title #685 Storybook 기능 추가하기 #685 Introduce Storybook and Vite Oct 27, 2023
@14KGun 14KGun requested review from cokia and withSang October 30, 2023 16:12
cokia
cokia requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@cokia cokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다 👍

vite.config.js Outdated Show resolved Hide resolved
src/tools/toast/index.tsx Outdated Show resolved Hide resolved
@14KGun 14KGun requested a review from cokia November 2, 2023 09:41
14KGun
14KGun reviewed Nov 2, 2023
View reviewed changes
src/components/Chat/index.tsx Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
14KGun
14KGun reviewed Nov 2, 2023
View reviewed changes
.prettierrc.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
14KGun
14KGun reviewed Nov 8, 2023
View reviewed changes
src/components/ModalPopup/Body/BodyRoomSelection.tsx Outdated Show resolved Hide resolved
src/components/Skeleton/index.tsx Outdated Show resolved Hide resolved
src/hooks/skeleton/useGoogleAnalyticsEffect.tsx Outdated Show resolved Hide resolved
src/hooks/skeleton/useI18nextEffect.tsx Show resolved Hide resolved
src/hooks/skeleton/useI18nextEffect.tsx Outdated Show resolved Hide resolved
src/pages/Addroom/index.tsx Outdated Show resolved Hide resolved
src/tools/loadenv.ts Outdated Show resolved Hide resolved
14KGun
14KGun approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

수고하셨습니다 ~~ 😄 😄

@14KGun 14KGun merged commit a955134 into dev Nov 12, 2023
4 checks passed
@14KGun 14KGun deleted the #685-add-storybook-to-taxi-front branch November 12, 2023 04:51
@14KGun 14KGun added the 🔨refactoring 기존의 코드를 리팩토링합니다 label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imYourChoi imYourChoi imYourChoi left review comments

@14KGun 14KGun 14KGun approved these changes

@jinhyeonkwon jinhyeonkwon Awaiting requested review from jinhyeonkwon

@withSang withSang Awaiting requested review from withSang

@cokia cokia Awaiting requested review from cokia

Assignees

@predict-woo predict-woo

Labels
🔨refactoring 기존의 코드를 리팩토링합니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Storybook vite 도입
6 participants
@predict-woo @cokia @withSang @14KGun @imYourChoi @jinhyeonkwon