#697 AWS-SDK V3으로 마이그레이션 #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
14KGun
reviewed
Dec 3, 2023
Comment on lines
77
to
86
| if (data.url) { | ||
| const res = await axiosOri({ | ||
| url: data.url, | ||
| method: "put", | ||
| headers: { | ||
| "Content-Type": image.type, | ||
| }, | ||
| data: image, | ||
| }); | ||
| if (res.status === 200) { |
There was a problem hiding this comment.
흠.. 채팅 사진 업로드는 코드 수정이 없어도 되나요?? @predict-woo
There was a problem hiding this comment.
@14KGun 헉 맞는 말이에요 수정하겠습니다
|
@predict-woo conflict 가 있어요! |
|
@14KGun 수정했습니다! |
14KGun
reviewed
Feb 8, 2024
Comment on lines
46
to
56
| const { url, fields, id } = await axios({ | ||
| const { url, id } = await axios({ | ||
| url: "chats/uploadChatImg/getPUrl", | ||
| method: "post", | ||
| data: { roomId, type: file.type }, | ||
| }); | ||
| if (!url || !fields || !id) throw new Error(); | ||
| if (!url || !id) throw new Error(); | ||
|
|
||
| const { status: s3Status } = await axiosOri({ | ||
| url, | ||
| method: "put", | ||
| data: file, | ||
| headers: { "Content-Type": file.type }, | ||
| }); | ||
|
|
||
| const formData = new FormData(); | ||
| for (const key in fields) formData.append(key, fields[key]); | ||
| formData.append("file", file); | ||
| const { status: s3Status } = await axiosOri.post(url, formData); |
There was a problem hiding this comment.
@predict-woo @cokia #323 이거 채팅 이미지 업로드가 되지 않는데, 에서 채팅 이미지 업로드 쪽 코드 수정은 아직 되지 않은 것 같긴 합니다??
xMHW
force-pushed
the
#697-aws-sdk-v3-migration
branch
from
25a4201
to
2d6bc84
Compare
|
Axios는 기본적으로 2xx 상태체크를 하고, 에러가 나는 경우 AxiosError 객체를 Throw합니다. 따라서, 필요없는 상태 체크 코드들을 제거 했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #697
Images or Screenshots
Further Work