Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 출석 체크 모달 스탬프가 찍히지 않음 #833

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Hyogyeong8
Copy link
Contributor

@Hyogyeong8 Hyogyeong8 commented Sep 15, 2024

modal when event is over

Summary

Images or Screenshots

image
->
image

Further Work

@Hyogyeong8 Hyogyeong8 self-assigned this Sep 15, 2024
@Hyogyeong8 Hyogyeong8 linked an issue Sep 15, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 6905230
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/66f1a2021bc93a00089f29e8
😎 Deploy Preview https://deploy-preview-833--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kmc7468
Copy link
Member

kmc7468 commented Sep 16, 2024

PR 타이틀 변경 부탁드립니다!

그리고 퀘스트 - 출석체크 페이지로 들어갔을 때 '오늘자 출석이 완료되었습니다.'로 버튼 텍스트가 고정되어 있는데, 로그인 여부 / 이벤트 참여 동의 여부 / 이벤트 기간에 따라서 텍스트가 적절히 바뀔 필요가 있어 보입니다! 상점 쪽에 있는 응모권 구입 버튼 참고하시면 좋을 것 같습니다.

@Hyogyeong8 Hyogyeong8 changed the title Fix: to show stamp today for daily attendance & hide daily attedance [Bug] 출석 체크 모달 스탬프가 찍히지 않음 Sep 23, 2024
@Hyogyeong8
Copy link
Contributor Author

완료하였습니다!

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmc7468 kmc7468 merged commit bdad0d0 into dev Sep 23, 2024
4 checks passed
@kmc7468 kmc7468 deleted the #832-bug-no-stamp-in-daily-attendance-check-modal branch September 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 출석 체크 모달 스탬프가 찍히지 않음
2 participants