Feature/separate scram endpoints #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emelieakerstrom-sb1
changed the base branch from
master
to
release-0.29-sb1
|
Jeg lurer på om vi må kjøre ListNodes her for å få riktig resultat? Siden zookeeper-nodenavnene ikke nødvendigvis har noe med broker-nodenavnene og antall |
Det är nog en bra ide, undviker onödiga problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint broker nodes have been provided in provider config as a comma separated string. CrossPlane customization cannot patch this string into a list of brokers, therefore I have added each endpoint as a separate key in the connection details.
Instead of
clusterEndpointSCRAM = "<endpoint1>,<endpoint2>,<endpoint3>"we can now use
added this for IAM, Plain, and TLS as well and kept the comma separated string connection details as well.