prefer caller_locations and Thread::Backtrace::Location methods to Kernel#caller
#638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we have test coverage for both class and instance methods' deprecation messages.
Mechanize has still been using `Kernel#caller` whose string representation has changed enough in Ruby 3.4.0.dev to break how deprecation messages were being handrolled. Replace all uses of `caller` with `caller_locations` which is both faster and returns an object with some nice methods we can use to isolate the method, the file, and the line number. This should get us green again on ruby-head.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanize has still been using
Kernel#callerwhose string representation has changed enough in Ruby 3.4.0.dev to break how deprecation messages were being handrolled.Replace all uses of
callerwithcaller_locationswhich is both faster and returns an object with some nice methods we can use to isolate the method, the file, and the line number.This should get us green again on ruby-head.