Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Parse options doc #3360

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

BurdetteLamar
Copy link
Contributor

What problem is this PR intended to solve?

Improvements to doc for XML::ParseOptions.

Have you included adequate test coverage?

N/A. All doc.

Does this change affect the behavior of either the C or the Java implementations?

No.

@flavorjones
Copy link
Member

Thank you for opening this! I apologize for not having made time to review this yet. I will do so in the next few days!

Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to circle back on this PR. Thank you so much for the time you've invested!

lib/nokogiri/xml/parse_options.rb Outdated Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Outdated Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Outdated Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Show resolved Hide resolved
lib/nokogiri/xml/parse_options.rb Outdated Show resolved Hide resolved
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I rebased onto origin/main and made a few small whitespace changes to please rubocop and make sure it's indented consistently.

@flavorjones flavorjones merged commit 65fa87c into sparklemotion:main Jan 22, 2025
15 of 16 checks passed
@flavorjones
Copy link
Member

Thank you so much, @BurdetteLamar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants