Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

108 convex hull #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

asturm-fe
Copy link
Contributor

@asturm-fe asturm-fe commented Apr 16, 2024

Add ConvexHull() method to clusters.PointList and clusters.Cluster types.

Add unit test for PointList.ConvexHull().
Implementation of Andrew's Monotone Chain algorithm (O(n log n) complexity with n = number of points).

closes #108

@coolwxb
Copy link
Contributor

coolwxb commented Apr 18, 2024

An error occurred during the compilation stage.
image

@asturm-fe
Copy link
Contributor Author

Oh my bad - I misread since when the builtin slices package was available. This is apparently a v1.21 feature and according to your go.mod, geoos is using go 1.19

I will refactor my code to use a version-appropriate sorting method.

Two things to consider though:

  1. Upgrade go to a more recent version to stay up-to-date with new features and improvements
  2. In the image you posted, the error says it could not find the package in ../go/1.18.10/... which is different from the go version specified in the go.mod - maybe you need to update your ci job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convex Hull
2 participants