Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
freekmurze committed Jul 8, 2019
1 parent f2e2e51 commit 2fb3697
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to `laravel-webhook-client` will be documented in this file

## 2.0.1 - 2019-07-08

- make `signing_secret` and `signature_header_name` config keys optional

## 2.0.0 - 2019-07-08

- `DefaultSignatureValidator` is now responsible for verifying that a signature header has been set
Expand Down
4 changes: 2 additions & 2 deletions src/WebhookConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ public function __construct(array $properties)
{
$this->name = $properties['name'];

$this->signingSecret = $properties['signing_secret'];
$this->signingSecret = $properties['signing_secret'] ?? '';

$this->signatureHeaderName = $properties['signature_header_name'];
$this->signatureHeaderName = $properties['signature_header_name'] ?? '';

if (! is_subclass_of($properties['signature_validator'], SignatureValidator::class)) {
throw InvalidConfig::invalidSignatureValidator($properties['signature_validator']);
Expand Down

0 comments on commit 2fb3697

Please sign in to comment.