Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve order in collections. #176

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

carmenerre
Copy link
Contributor

This MR tries to solve #146

It replaces the use of HashMap with LinkedHashMap, which preserves the performance improvement done in #144 but keeps the insertion order in collections.

Because LinkedHashMap is not synchronized, it has been wrapped using Collections.synchronizedMap method.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carmenerre - great improvement to the code.

@goneall goneall merged commit 182ffa6 into spdx:master May 31, 2023
@beltran-rubo
Copy link

@goneall any ETA for a new release in June? This is a great improvement, thanks.

@goneall
Copy link
Member

goneall commented Jun 8, 2023

@beltran-rubo - would you want a complete release of all the java tools or just this library? I could spin the library version pretty quickly if it helps. Otherwise, it will probably be towards the end of June for a release of the complete set of Java tools as I'm working on a release of the online tools over the next week or two.

@beltran-rubo
Copy link

We are using the Java library itself, it would be great to get it sooner than later including this improvement. Thanks!

@goneall
Copy link
Member

goneall commented Jun 8, 2023

We are using the Java library itself, it would be great to get it sooner than later including this improvement. Thanks!

In that case I'll plan on producing a release of this library over the next couple of days.

@goneall
Copy link
Member

goneall commented Jun 8, 2023

@beltran-rubo - Totally different topic - as a user of the library directly, would you be interested, available to review the approach and design for the SPDX 3 changes? I'm just starting to implement and there are some breaking changes I'd like to get feedback on before going too far.

I just created #178 to track feedback prior to a pull request being created.

@beltran-rubo
Copy link

Thanks! Still a bit early to move to version 3 on our side but we can help with the revision and testing.

@goneall
Copy link
Member

goneall commented Jun 12, 2023

@beltran-rubo The release with this fix has been published: https://github.com/spdx/Spdx-Java-Library/releases/tag/v1.1.7
It should be available in Maven Central soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants