Add VS Code validation and common errors #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bact
commented
Jun 17, 2024
•
bact
commented
- Add how to enable real-time validation in Visual Studio Code
- Add common errors
- Update schema filename in ajv command line to match the name in wget (spdx-3-schema.json) command line example
- Add how to enable real-time validation in Visual Studio Code - Add common errors - Update schema filename in ajv command line to match the name in wget (spdx-3-schema.json) Signed-off-by: Arthit Suriyawongkul <[email protected]>
6 tasks
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
@rgopikrishnan91 and this one for the real-time validation in VS Code |
bact
commented
Jul 10, 2024
Comment on lines
+128
to
+137
| ```json | ||
| "json.schemas": [ | ||
| { | ||
| "fileMatch": [ | ||
| "*.spdx3.json" | ||
| ], | ||
| "url": "https://spdx.org/schema/3.0.0/spdx-json-schema.json" | ||
| } | ||
| ] | ||
| ``` |
There was a problem hiding this comment.
Clause 4: Conformance in v2.3 suggests naming convention of *.spdx.json.
v3.0 has no chapter on conformance yet.
This can be modified to whatever agreed in spdx/spdx-spec#987
goneall
approved these changes
Jul 22, 2024
|
This helps the VS folks, and isn't passing through into the spec, so going ahead and including. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.