Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bullet rendering in how-to-use #825

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

briandealwis
Copy link

The bullets in K.1 are not rendering correctly:

Screen Shot 2022-12-16 at 11 00 01 AM

This PR introduces a blank line and uses * bullet style as used elsewhere (such as chapters/conformance.md)

Add blank line and use `*` bullet style as used elsewhere (such as chapters/conformance.md)

Signed-off-by: Brian de Alwis <[email protected]>
@briandealwis briandealwis changed the title Fix how-to-use bullet rendering Fix bullet rendering in how-to-use Dec 16, 2022
@goneall
Copy link
Member

goneall commented Apr 4, 2024

@jeff-schutt - we should include this fix in any updates to the how to use Annex

@zvr
Copy link
Member

zvr commented Aug 28, 2024

This should be closed, since the document in question is no longer in this repo.

@bact
Copy link
Collaborator

bact commented Aug 28, 2024

The document in this PR is in development/v2.3.1 branch, which has never been published (ref gh-pages branch for published versions).

However, the development/v2.3 branch also has the same document, with the same list rendering problem - published at https://spdx.github.io/spdx-spec/v2.3/how-to-use/

If a fix is needed for the published one, it should target the branch development/v2.3 instead (or both v2.3 and v2.3.1).

Update: the fix for v2.3 is created at #1114

@bact
Copy link
Collaborator

bact commented Sep 7, 2024

#1115 is partly duplicated with this one.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll go ahead and merge, although it won't impact the published version until 2.3.1 is released.

@goneall goneall merged commit 62f3e7c into spdx:development/v2.3.1 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants