Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Republish 3.0 as 3.0.0 #994

Closed
wants to merge 13 commits into from
Closed

Republish 3.0 as 3.0.0 #994

wants to merge 13 commits into from

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 18, 2024 •
edited
Loading

What this PR do?

Allow users to get access to the original v3.0 (v3.0.0) content, after the v3.0.1 overtake the "v3.0" as an alias.

Changes

  • in .github/workflows/publish_v3.yml:

    • Update actions/checkout to v4 to prevent build warning of Node.js deprecation
    • Use 3.0 tag release of spdx-model
    • Deploy using v3.0.0 version

  • in mkdocs.yml:

    • Set metadata to use v3.0.0 as a version, including canonical_version: v3.0.0

Notes

bact added 4 commits July 18, 2024 08:19
@bact
Set 3.0.0 as latest until 3.0.1 is ready
5d63613 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use -u to update alias to different version
2f5966f 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Reorder arguments
c143228 
Use the same order as in "mike deploy -h" for easy ref.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add site description
c617260 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Jul 18, 2024
Merged
@bact
Copy link
Collaborator Author

bact commented Jul 18, 2024 •
edited
Loading

Build failed because of invalid JSON-LD examples inside an Annex.

Fixed in post-3.0 release by 389566e, which is not included in the build because the build checkout 3.0.

@bact
Fix yaml indent
05144f4 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact mentioned this pull request Jul 23, 2024
Closed
bobmartin3000
bobmartin3000 approved these changes Aug 2, 2024
View reviewed changes
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bact
Update GitHub Actions/Python package versions
8ab67e3 
- Update GitHub Actions Checkout version
- Update Python package versions in requirements.txt
- Set v3.0 aliases to v3.0.0, v3.0-RC1, v3.0-RC2

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Fix validate PR workflow
8c3ebc1 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Fix validate examples workflow
5ec58fa 
Fix validate examples workflow,
using commit 389566e
- Fix examples inside including-security-information-in-SPDX.md
- Update dependencies

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add execute permissino to check-examples.sh
f1eb56f 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Aug 2, 2024

Add validation examples changes from commit 389566e.

All checks have passed.

@bact
Fix canonical URL
c0dd93e 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact changed the title Publish 3.0.0 as latest Republish 3.0 as 3.0.0 Aug 3, 2024
@bact
Copy link
Collaborator Author

bact commented Aug 3, 2024 •
edited
Loading

@bobmartin3000 Thank you for the review. Please be notified that this PR has changed its target a bit - to anticipated with the coming release of 3.0.1 and changes in #1015. Because of that, I have re-request the review (to reset your previous review).

@bact bact mentioned this pull request Aug 3, 2024
Closed
@bact
Use redirect for alias
d6fcc9d 
So the URL in the browser changes

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from bobmartin3000 August 3, 2024 08:43
bobmartin3000
bobmartin3000 suggested changes Aug 3, 2024
View reviewed changes
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to withdraw my approval but can't figure out how to do that.

@bact
Copy link
Collaborator Author

bact commented Aug 4, 2024

I agree to withdraw my approval but can't figure out how to do that.

Your approval has already been withdrawn when I re-request the review.

@bact bact mentioned this pull request Aug 5, 2024
Closed
@goneall goneall added this to the 3.0.1 milestone Aug 9, 2024
@bact
Update copyright line and v3.0.0
c2b3bb4 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove OMG (OMG is not yet in 3.0)
7900d6b 
Signed-off-by: Arthit Suriyawongkul ([email protected])
@kestewart
Copy link
Contributor

Not essential for 3.0.1 pdf spec publishing.

@licquia licquia self-requested a review August 13, 2024 16:34
@bact bact marked this pull request as draft August 27, 2024 18:43
@bact
Copy link
Collaborator Author

bact commented Nov 13, 2024

Close. Will open a new PR for this once branch renaming is done and a new publishing workflow is updated to support the publication from the "support" branch.

@bact bact closed this Nov 13, 2024
@bact bact deleted the publish-3.0.0-as-latest branch November 13, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobmartin3000 bobmartin3000 bobmartin3000 requested changes

@licquia licquia Awaiting requested review from licquia

Assignees
No one assigned
Labels
publishing
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bact @kestewart @bobmartin3000 @goneall