Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter taxon only when field relates to Taxon table #6161

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Filter taxon only when field relates to Taxon table #6161

merged 1 commit into from
Jan 28, 2025

Conversation

sharadsw
Copy link
Contributor

Fixes #6156

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to a CO form
  • Add determination
  • Verify determiner does not have duplicates

@sharadsw sharadsw added this to the 7.10.1 milestone Jan 27, 2025
@sharadsw sharadsw requested review from CarolineDenis and a team January 27, 2025 21:09
@acwhite211 acwhite211 self-requested a review January 27, 2025 21:12
acwhite211
acwhite211 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@acwhite211 acwhite211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Areyes42
Areyes42 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify determiner does not have duplicates

No more duplicates 👍
Screenshot 2025-01-27 at 3 47 24 PM

pashiav
pashiav approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify determiner does not have duplicates

Looks good!

@sharadsw sharadsw merged commit 9578632 into production Jan 28, 2025
12 checks passed
@sharadsw sharadsw deleted the issue-6156 branch January 28, 2025 14:20
@sharadsw sharadsw changed the title Filter taxon only when field relates to Taxon Filter taxon only when field relates to Taxon table Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Areyes42 Areyes42 Areyes42 approved these changes

@pashiav pashiav pashiav approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@acwhite211 acwhite211 acwhite211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.10.1
Development

Successfully merging this pull request may close these issues.

Duplicate results for determiner querycombobox search
5 participants
@sharadsw @acwhite211 @CarolineDenis @pashiav @Areyes42