Update deprecated navigator.appVersion function #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acwhite211
requested review from
weblate,
maxpatiiuk,
melton-jason,
CarolineDenis and
sharadsw
CarolineDenis
removed request for
sharadsw,
maxpatiiuk,
melton-jason and
CarolineDenis
Triggered by dacec9e on branch refs/heads/issue-6129
CarolineDenis
approved these changes
Jan 28, 2025
sharadsw
approved these changes
Jan 28, 2025
grantfitzsimmons
approved these changes
Jan 28, 2025
|
The fix introduced in this PR has actually already been addressed and implemented in a PR! 😅: #5389 Could we merge that PR as well? There is still some value in its implementation, so it probably shouldn't be closed |
|
@melton-jason, yes we should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6129
It seems this line is causing the weblate localization workflow to fail:
specify7/specifyweb/frontend/js_src/lib/components/Preferences/UserDefinitions.tsx
Lines 67 to 69 in 9578632
Example error: https://github.com/specify/specify7/actions/runs/12128718100/job/33815688425
The
navigator.appVersionfunction has been deprecated and can be replaced withnavigator.userAgentin order to get platform information, like the user's OS. This change will also handle both browser and non-browser environments.Once this is merged into production, the weblate localization workflow will run again and we can see if any other issues occur.
Checklist
self-explanatory (or properly documented)
Testing instructions
No testing now, need to merge into production and test the weblate localization workflows.