Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name for parent COG name in QB results instead of Arent #6168

Open
wants to merge 3 commits into
base: production
Choose a base branch
from

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Jan 28, 2025

Fixes #6165

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Open QB with COG table
  • Add COJO > Parent > Name
  • Click Query
  • Verify that the column has 'name' as a header and not 'Arent'

@CarolineDenis CarolineDenis added this to the 7.10.1 milestone Jan 28, 2025
@CarolineDenis CarolineDenis requested review from sharadsw and a team and removed request for a team and sharadsw January 28, 2025 18:19
@CarolineDenis CarolineDenis marked this pull request as draft January 28, 2025 21:17
@CarolineDenis CarolineDenis marked this pull request as ready for review January 29, 2025 17:42
@CarolineDenis CarolineDenis requested a review from a team January 29, 2025 17:43
@lexiclevenger
Copy link
Collaborator

Testing instructions

  • Open QB with COG table
  • Add COJO > Parent > Name
  • Click Query
  • Verify that the column has 'Name' as a header and not 'Arent'

Looks good!

Screenshot 2025-02-04 at 2 01 10 PM

@CarolineDenis CarolineDenis requested review from a team and acwhite211 February 4, 2025 20:10
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the column has 'Name' as a header and not 'Arent'

On db ciscollections_2_15_24, it is now called 'name' but it isn't capitalized.

Screenshot 2025-02-05 at 12 06 37 PM

Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase in schema config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dev Attention Needed
Development

Successfully merging this pull request may close these issues.

Parent column in QB results for COJO > Parent > Name is 'Arent'
5 participants