-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a button to download default trees #6188
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Open the tree viewer for Taxon
- Verify that there is no Download New Tree icon under the first rank if the tree has nodes (other than root)
- Verify that there is the Download New Tree icon under the + Icon (Create Root Node) in the first rank column for new empty trees
- Verify that there is the Download New Tree icon under Root in the first rank column for trees that only have a root node
- Verify that clicking the new icon opens
https://files.specifysoftware.org/taxonfiles/
with a list of default trees to download from
Looks good! One thing I noticed--when starting from an empty tree or one with a root node, the download button stays after you add nodes until the page is refreshed. Is this acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify that there is no Download New Tree icon under the first rank if the tree has nodes (other than root)
- Verify that there is the Download New Tree icon under the + Icon (Create Root Node) in the first rank column for new empty trees
- Verify that there is the Download New Tree icon under Root in the first rank column for trees that only have a root node
- Verify that clicking the new icon opens
https://files.specifysoftware.org/taxonfiles/
with a list of default trees to download from
On already existing trees with more than just the root node there is no dowload button but if you create a new tree and add another node the download button stays there until refresh. This isn't necessarily a huge problem but could be confusing to users
02-26_14.13.mp4
@emenslin , it will be there only the first time, what I mean is that the next time you go back to the tree viewer or if you reload the page the folder icon will disappear. |
Fixes #6123
Checklist
self-explanatory (or properly documented)
Testing instructions
New icon introduced:

https://files.specifysoftware.org/taxonfiles/
with a list of default trees to download fromTODO:
https://files.specifysoftware.org/taxonfiles/
for what to do with the dowloaded tree