Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip for required fields in bulk carry forward config #6202

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

Add tooltip for required fields in bulk carry forward config #6202

wants to merge 3 commits into from
+11 −1

Conversation

Areyes42
Copy link
Contributor

@Areyes42 Areyes42 commented Feb 5, 2025 •
edited
Loading

Fixes #5202

$~$
This PR adds a new tooltip for required fields in the bulk carry forward config. Previously, hovering over a required field would only display the default field name.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)

Testing instructions

  • Go to a Collection Object record
  • Click the form meta button
  • Click on "Show Carry Forward button"
  • Click on the gear icon next to "Show Bulk Carry Forward button"
  • Hover over a required field (may need to check 'Reveal Hidden Form Fields')
  • Verify the new required tooltip is displayed/correct

@Areyes42 Areyes42 linked an issue Feb 5, 2025 that may be closed by this pull request
No tooltip for required fields in bulk carry forward config #5202
Open
@Areyes42 Areyes42 marked this pull request as ready for review February 7, 2025 18:21
@Areyes42 Areyes42 added this to the 7.10.1 milestone Feb 7, 2025
@Areyes42 Areyes42 requested review from a team February 7, 2025 18:22
@CarolineDenis CarolineDenis self-requested a review February 7, 2025 18:44
emenslin
emenslin approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the new required tooltip is displayed/correct

Looks good!
Screenshot 2025-02-07 154740

@emenslin emenslin requested a review from a team February 7, 2025 21:50
combs-a
combs-a approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the new required tooltip is displayed/correct

image

Is there, all of the other tooltips still look good as well. Looks good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadsw sharadsw sharadsw approved these changes

@combs-a combs-a combs-a approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@emenslin emenslin emenslin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: 📋Back Log
Milestone
7.10.2
Development

Successfully merging this pull request may close these issues.

No tooltip for required fields in bulk carry forward config
5 participants
@Areyes42 @sharadsw @combs-a @CarolineDenis @emenslin