Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select formatter in field schema config #6255

Open
wants to merge 3 commits into
base: production
Choose a base branch
from

Conversation

CarolineDenis
Copy link
Contributor

Fixes #6250

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to Schema Config -> Any table
  • Under Field Format, select "Formatted"
  • Verify it gets selected

@CarolineDenis CarolineDenis added this to the 7.10.2 milestone Feb 18, 2025
@CarolineDenis CarolineDenis requested a review from a team February 21, 2025 16:12
@lexiclevenger
Copy link
Collaborator

Is the schema config supposed to automatically pick a formatter that is configured for the selected field? This seems to happen in production but not this branch.

Production

Screen.Recording.2025-02-21.at.11.46.12.AM.mov

This branch:

Screen.Recording.2025-02-21.at.11.55.02.AM.mov

@CarolineDenis
Copy link
Contributor Author

@lexiclevenger, good catch

Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify it gets selected

Looks good, the issue from my previous comment is resolved!

@CarolineDenis CarolineDenis requested review from a team and acwhite211 February 24, 2025 14:18
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify it gets selected

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

"Formatted" Field Format Not Auto-Selecting
5 participants