Sped up Rhino receive hot spots #596
Open
+71
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #596 +/- ##
========================================
- Coverage 8.76% 8.75% -0.01%
========================================
Files 227 228 +1
Lines 4346 4350 +4
Branches 546 548 +2
========================================
Hits 381 381
- Misses 3950 3954 +4
Partials 15 15 ☔ View full report in Codecov by Sentry. |
oguzhankoral
requested changes
Feb 25, 2025
|
|
||
| namespace Speckle.Converters.Rhino.ToHost.Raw; | ||
|
|
||
| public static class RhinoPools |
There was a problem hiding this comment.
Could you add here why this pools are introduced etc? for performance reasons, what was the problem that it fixed
| public Point3dList Convert(IReadOnlyList<double> target) | ||
| public Point3dList Convert(IReadOnlyList<double> target) => new(ConvertToEnum(target)); | ||
|
|
||
| public IEnumerable<RG.Point3d> ConvertToEnum(IReadOnlyList<double> target) |
There was a problem hiding this comment.
what is the benefit of convertin enum here? need more inline docs to remember later the reasoning
There was a problem hiding this comment.
It's avoiding temporary collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple of hot spots in Rhino receive mostly around Mesh conversions. Avoid making intermediate structs and pool objects where it makes sense with the API
Conversion total before: 15 secs
After: 8.5 seconds
