Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autocad perf - Adds early exit to idle manager to shortcut call check #609

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

adamhathcock
Copy link
Member

Since Autocad calls object changed on each receive, this shaves off 7 seconds off my test. Also fixes a namespace

Should talk about Transactions vs StartStop ones

before:
Screenshot 2025-02-19 161647

after:
Screenshot 2025-02-19 173121

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.66%. Comparing base (76aa953) to head (27771cc).

Files with missing lines Patch % Lines
...3/Speckle.Connectors.DUI/Bridge/IdleCallManager.cs 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #609      +/-   ##
========================================
- Coverage   8.71%   8.66%   -0.05%     
========================================
  Files        229     229              
  Lines       4373    4373              
  Branches     548     549       +1     
========================================
- Hits         381     379       -2     
- Misses      3977    3978       +1     
- Partials      15      16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral marked this pull request as draft February 20, 2025 11:16
@oguzhankoral
Copy link
Member

Since this PR touches the IdleManager which would effect the all connectors that means need to be tested widely. I would rather to have this imporevements in after end of Feb release. Thats why i marked it as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants