Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hosted element area to parameters in Revit. #3539

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
+35 −0
Open

Add hosted element area to parameters in Revit. #3539

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e15861
covnersion added
ks-cph Jun 27, 2024
2c06eda
null
ks-cph Jun 27, 2024
c31aba1
params null
ks-cph Jun 27, 2024
aed69b0
proj
ks-cph Jun 27, 2024
3b88b25
Merge branch 'specklesystems:main' into revit-window-door-area
ks-cph Aug 17, 2024
8d8eb4a
Merge branch 'dev' into revit-window-door-area
JR-Morgan Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using Speckle.Core.Models;
using Speckle.Core.Models.Extensions;
using DB = Autodesk.Revit.DB;
using IFC = Autodesk.Revit.DB.IFC;
using Level = Objects.BuiltElements.Level;
using Line = Objects.Geometry.Line;
using Parameter = Objects.BuiltElements.Revit.Parameter;
Expand Down Expand Up @@ -144,6 +145,23 @@ out List<string> notes
status: ApplicationObject.State.Created,
logItem: $"Attached as hosted element to {host.UniqueId}"
);

double area = GetAreaOfHostedElement(element as DB.FamilyInstance, host as DB.Wall);
#if REVIT2020
double area_transformed = UnitUtils.ConvertFromInternalUnits(area, DisplayUnitType.DUT_SQUARE_METERS);
#else
double area_transformed = UnitUtils.ConvertFromInternalUnits(area, UnitTypeId.SquareMeters);
#endif
var paramObject = obj["parameters"];
if( paramObject != null )
{
Base parameters = (Base)paramObject;
if (parameters != null)
{
Objects.BuiltElements.Revit.Parameter hostedAreaParameter = new Parameter("Cutout Area", area_transformed, "m²");
parameters["Cutout Area"] = hostedAreaParameter;
}
}
convertedHostedElements.Add(obj);
ConvertedObjects.Add(obj.applicationId);
}
Expand Down Expand Up @@ -1108,6 +1126,23 @@ public WallLocationLine GetWallLocationLine(LocationLine location)
}
}

/// <summary>
/// Computes the area of an object in a Host element
/// </summary>
/// <param name="hostedElement"></param>
/// <param name="host"></param>
/// <returns></returns>
public double GetAreaOfHostedElement(DB.FamilyInstance hostedElement, Wall host)
{
XYZ basisY = XYZ.BasisY;
CurveLoop curveLoop = IFC.ExporterIFCUtils.GetInstanceCutoutFromWall(host.Document, host, hostedElement, out basisY);
IList<CurveLoop> loops = new List<CurveLoop>(1);
loops.Add(curveLoop);
double area_sqft = IFC.ExporterIFCUtils.ComputeAreaOfCurveLoops(loops);
return area_sqft;
}


#region materials
public RenderMaterial? GetElementRenderMaterial(DB.Element? element)
{
Expand Down