Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename append mirrors to prepend existing #750

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

phillebaba
Copy link
Member

This change renames append mirrors to prepend existing. The new name makes it more clear what the setting actually does also removes a flag with the word mirrors, as there are a lot of them.

Fixes #617

@phillebaba phillebaba force-pushed the fix/append-mirror-name branch from 71e0b27 to 4fb7505 Compare February 25, 2025 12:10
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
main.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/oci/containerd.go 54.69% <100.00%> (ø)
main.go 0.00% <0.00%> (ø)

@phillebaba phillebaba merged commit af3d364 into main Feb 25, 2025
9 checks passed
@phillebaba phillebaba deleted the fix/append-mirror-name branch February 25, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append wrongly named / Missing docs
1 participant