-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The previous implementation of the logic to catch whether a `rank` passed to `partition.indexers` was valid was incorrect. The minus one is on the wrong side of the inequality; it should be either `rank > ranks - 1`, or, as I've implemented things now, `rank >= ranks`. This PR adds a test and fixes this issue. In practice this was not a big deal, because it just meant that sometimes we would not trigger the error when we should have.
- Loading branch information
1 parent
9af1c6c
commit ef9a665
Showing
2 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters