Skip to content

Commit

Permalink
Remove explicit default method calls
Browse files Browse the repository at this point in the history
  • Loading branch information
spencewenski committed Jan 8, 2024
1 parent 460a451 commit aedf8c1
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/renderer/markdown_renderer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub struct MarkdownRenderer;

impl MarkdownRenderer {
pub fn new() -> MarkdownRenderer {
MarkdownRenderer::default()
MarkdownRenderer
}
}

Expand Down
8 changes: 4 additions & 4 deletions src/renderer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ trait Renderer<I, O> {

pub fn render_resume(resume: &Resume, config: &Config) -> Result<(), String> {
let renderers: Vec<Box<dyn Renderer<Resume, PathBuf>>> = vec![
Box::new(TextRenderer::default()),
Box::new(PdfRenderer::default()),
Box::new(MarkdownRenderer::default()),
Box::new(GitHubRenderer::default()),
Box::<TextRenderer>::default(),
Box::<PdfRenderer>::default(),
Box::<MarkdownRenderer>::default(),
Box::<GitHubRenderer>::default(),
];
renderers.iter().try_for_each(|x| -> Result<(), String> {
x.render(resume, config)?;
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/pdf_renderer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pub struct PdfRenderer;

impl PdfRenderer {
pub fn new() -> PdfRenderer {
PdfRenderer::default()
PdfRenderer
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/renderer/text_renderer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@ use crate::util::{
cover_letter_file_name, date_string, split_string_across_lines, time_range_string,
write_string_to_file, FooterText,
};
use std::ops::Deref;
use std::path::PathBuf;

#[derive(Default)]
pub struct TextRenderer;

impl TextRenderer {
pub fn new() -> TextRenderer {
TextRenderer::default()
TextRenderer
}
}

Expand Down

0 comments on commit aedf8c1

Please sign in to comment.