Print Default Values of String-to-String in Sorted Order #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhargav Ravuri <[email protected]>
|
what about string to other types like integers? |
Yes, there are another 2 places. Let this PR be a PoC. We can have set of issue-PR to address those.
|
fredbi
approved these changes
Nov 21, 2022
SOF3
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue 362 reported by @SOF3
Changes
Sort keys before stringifying string-to-string flag values.
Summary
String-to-string default values in usage would print in sorted order of keys.
Eg.
--foo stringToString usage (default [a=b,c=d])In the example as per #362, now, the order will be always
default [a=b,c=d]Related Issues
Closes #362