Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: one NIC's IP pool shortage depleted IPs of other NICs in a multi-NIC setup. #4383

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Dec 11, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4381

Special notes for your reviewer:

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (90ac1e2) to head (b273c18).
Report is 2 commits behind head on release-v0.9.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.9    #4383      +/-   ##
================================================
- Coverage         81.54%   81.00%   -0.55%     
================================================
  Files                50       50              
  Lines              5446     5453       +7     
================================================
- Hits               4441     4417      -24     
- Misses              837      874      +37     
+ Partials            168      162       -6     
Flag Coverage Δ
unittests 81.00% <100.00%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_manager.go 82.96% <100.00%> (-2.21%) ⬇️

... and 1 file with indirect coverage changes

@weizhoublue weizhoublue merged commit 2bc4a1c into spidernet-io:release-v0.9 Dec 11, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants