Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fail to create statefulSet applications in multi-NIC scenarios. #4389

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Dec 11, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4388

Special notes for your reviewer:

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.36%. Comparing base (6e383aa) to head (93aff81).
Report is 2 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
...orkloadendpointmanager/workloadendpoint_manager.go 55.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #4389      +/-   ##
================================================
- Coverage         79.50%   79.36%   -0.14%     
================================================
  Files                51       51              
  Lines              5783     5802      +19     
================================================
+ Hits               4598     4605       +7     
- Misses             1022     1032      +10     
- Partials            163      165       +2     
Flag Coverage Δ
unittests 79.36% <57.14%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_manager.go 84.61% <100.00%> (ø)
...orkloadendpointmanager/workloadendpoint_manager.go 95.40% <55.00%> (-4.60%) ⬇️

... and 1 file with indirect coverage changes

@weizhoublue weizhoublue changed the title Fix: statefulSet applications failed to create in multi-NIC scenarios. Fix: fail to create statefulSet applications in multi-NIC scenarios. Dec 11, 2024
@weizhoublue weizhoublue merged commit 9b5fd92 into spidernet-io:release-v1.0 Dec 11, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants