Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multus to v4 & fix multus fails to reach api server when the old service account is out of data #4460

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

fixes #4456

Special notes for your reviewer:

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (7a0dd79) to head (4cb391e).
Report is 4 commits behind head on release-v0.8.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-v0.8    #4460   +/-   ##
=============================================
  Coverage         80.86%   80.86%           
=============================================
  Files                49       49           
  Lines              5446     5446           
=============================================
  Hits               4404     4404           
  Misses              880      880           
  Partials            162      162           
Flag Coverage Δ
unittests 80.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cyclinder
Copy link
Collaborator Author

CI 可忽略,可合入

@weizhoublue
Copy link
Collaborator

this ci seems to matter with the chart
https://github.com/spidernet-io/spiderpool/actions/runs/12543145951/job/34973848416?pr=4460

go: warning: "./..." matched no packages
rm -f *.tgz
go: warning: "./..." matched no packages
: " Updating Chart version to v0.8.8"
echo "VERSION_MAJOR="
VERSION_MAJOR=
echo "GIT_VERSION="
GIT_VERSION=
echo "FULL_BUILD_VERSION=v0.8.8 672c8e5cd69f62c613a816b71557e4076b157edb"
FULL_BUILD_VERSION=v0.8.8 672c8e5cd69f62c613a816b71557e4076b157edb
\
	spiderpool_version="v0.8.8";		\
	chart_version=` echo v0.8.8 | tr -d 'v' ` ; \
	sed -i 's/version: "*''[vV]*[0-9]\+\.[0-9]\+\.[0-9]\+.*''"*/version: '$chart_version'/g' "./spiderpool/Chart.yaml";		\
	sed -i 's/appVersion: "*''[vV]*[0-9]\+\.[0-9]\+\.[0-9]\+.*''"*/appVersion: "'$chart_version'"/g' "./spiderpool/Chart.yaml";	\
	sed -i 's/tag: ""/tag: '$spiderpool_version'/g' "./spiderpool/values.yaml"
helm lint --with-subcharts --values ./spiderpool/values.yaml ./spiderpool
Error: 1 chart(s) linted, 1 chart(s) failed
==> Linting ./spiderpool
Error:  templates/daemonset.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 206: did not find expected key

@cyclinder
Copy link
Collaborator Author

docker.io/openkruise/kruise-helm-hook:v0.1.0
Image: "openkruise/kruise-helm-hook:v0.1.0" with ID "sha256:ac7049d52f06d5f37229f6abea772d01a0badaee6cb3e71e118b73f98a04280e" not yet present on node "spiderpool1231024931-worker", loading...
Image: "openkruise/kruise-helm-hook:v0.1.0" with ID "sha256:ac7049d52f06d5f37229f6abea772d01a0badaee6cb3e71e118b73f98a04280e" not yet present on node "spiderpool1231024931-control-plane", loading...
# https://github.com/spidernet-io/spiderpool/issues/4396
/etc/bash.bashrc: line 7: PS1: unbound variable
make[3]: *** [Makefile:187: setup_kurise] Error 1
make[3]: Leaving directory '/home/runner/work/spiderpool/spiderpool/test'
make[2]: *** [Makefile:39: kind-init] Error 2
make[2]: Leaving directory '/home/runner/work/spiderpool/spiderpool/test'
make[1]: *** [Makefile:298: e2e_init] Error 2
make[1]: Leaving directory '/home/runner/work/spiderpool/spiderpool'
make: *** [Makefile:322: e2e_init_underlay] Error 2

ignore the upgrade CI failed

@weizhoublue weizhoublue merged commit 34320bf into spidernet-io:release-v0.8 Dec 31, 2024
49 of 51 checks passed
@cyclinder cyclinder mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 4393 from cyclinder, to branch release-v0.8
2 participants