Extends controller-runtime with new metric #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
…oller-manager into prom-metrics
| @@ -42,11 +42,13 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/healthz" | |||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | |||
| "sigs.k8s.io/controller-runtime/pkg/manager" | |||
| k8sMetrics "sigs.k8s.io/controller-runtime/pkg/metrics" | |||
There was a problem hiding this comment.
Suggested change
| k8sMetrics "sigs.k8s.io/controller-runtime/pkg/metrics" | |
| k8smetrics "sigs.k8s.io/controller-runtime/pkg/metrics" |
| @@ -78,6 +80,10 @@ func init() { | |||
| utilruntime.Must(clientgoscheme.AddToScheme(scheme)) | |||
|
|
|||
| utilruntime.Must(spirev1alpha1.AddToScheme(scheme)) | |||
|
|
|||
| k8sMetrics.Registry.MustRegister( | |||
There was a problem hiding this comment.
Suggested change
| k8sMetrics.Registry.MustRegister( | |
| k8smetrics.Registry.MustRegister( |
azdagron
previously approved these changes
Oct 1, 2024
Signed-off-by: kfox1111 <[email protected]>
kfox1111
reviewed
Oct 3, 2024
Signed-off-by: kfox1111 <[email protected]>
|
Thanks for testing this IRL, @kfox1111! |
Signed-off-by: Andrew Harding <[email protected]>
azdagron
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends controller runtime metrics adding prometheus metrics to count cluster static entries failures
Fix issue #278