Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi year investment tutorial #1048

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Conversation

gnawin
Copy link
Collaborator

@gnawin gnawin commented Jul 19, 2024

(description of changes)

Fixes #1041

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

@gnawin gnawin force-pushed the add-multi-year-investment-tutorial branch from 96cf0ab to c4383a0 Compare July 19, 2024 15:59
@tarskul
Copy link
Collaborator

tarskul commented Jul 22, 2024

There was a tutorial missing on capacity planning. That is now in the works (#1049). This tutorial should build on that. Both tutorials are perhaps even small enough to be combined into one.

@gnawin
Copy link
Collaborator Author

gnawin commented Jul 22, 2024

Thanks and good to know @tarskul. After checking #1049, I think we can merge these two because basically everything mentioned in that tutorial is already covered in this one and this one takes it even further by talking about details of milestone years. So I propose to close that one, and you can add to this PR if wanted.

@tarskul
Copy link
Collaborator

tarskul commented Jul 22, 2024

Ah, uhm, I already merged it to master. But don't worry, I'll combine them later. Is this branch based on master or an experimental branch? If it is based on master, I can merge master into add-multi-year-tutorial and then combine the tutorials.

@gnawin
Copy link
Collaborator Author

gnawin commented Jul 22, 2024

No worries. It is based on master (after your recent doc overhaul at least).

@gnawin gnawin marked this pull request as ready for review July 23, 2024 12:24
@gnawin gnawin requested a review from tarskul July 23, 2024 12:25
@gnawin
Copy link
Collaborator Author

gnawin commented Jul 23, 2024

@tarskul I added the missing figures. You may want to merge this after you align with the other tutorial.

Or maybe it is more convenient if we keep both for now, and do something later because they talk about slightly different topics, and I can soon expand this tutorial with more economic representations. If so, I'll just add a reference to the other tutorial and merge this.

@tarskul
Copy link
Collaborator

tarskul commented Jul 23, 2024

@gnawin In a local branch I'm trying to combine the two tutorials as they are both about capacity planning. I'll see how that goes. But if more tutorials are coming, we should perhaps list them in #735 such that we have an overview and can see what would fit where exactly. If there are indeed many things they could perhaps become an 'advanced' tutorial. We'll see.

@gnawin
Copy link
Collaborator Author

gnawin commented Jul 23, 2024

Cool! There will not be more tutorials from my side, but my plan is to populate this tutorial by adding more stuff about using economic parameters. I can start populate once this has been merged.

And I list the multi-year tutorial in #735 along side your capacity planning tutorial. That is a separate issue/tutorial because it is part of the multi-year investment epic #908

@tarskul
Copy link
Collaborator

tarskul commented Jul 24, 2024

This is what I have so far. I think it works as a tutorial. I'll just have to try the tutorial myself and see whether it also actually runs.

If that is ok with you, then we may ship it soon.

As for the other economic parameters, let's discuss them at some point to see whether it makes more sense to add them to this tutorial or to make a separate tutorial for them.

@tarskul tarskul removed their request for review July 25, 2024 13:44
@gnawin
Copy link
Collaborator Author

gnawin commented Jul 25, 2024

Yes, if everything works, you can merge this.

@tarskul tarskul merged commit 0b30461 into master Jul 25, 2024
5 checks passed
@tarskul tarskul deleted the add-multi-year-investment-tutorial branch July 25, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change temporal structure for investment and operation blocks in multi-year investments
2 participants