Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

751-add-reserves-tutorial #756

Closed
wants to merge 41 commits into from
Closed

751-add-reserves-tutorial #756

wants to merge 41 commits into from

Conversation

datejada
Copy link
Member

@datejada datejada commented Sep 26, 2023

Add reserve tutorial for SpineOpt

Fixes # 751

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

@datejada datejada linked an issue Sep 26, 2023 that may be closed by this pull request
@datejada datejada self-assigned this Sep 26, 2023
DillonJ and others added 16 commits September 26, 2023 18:13
sum demand and uaf only over rep windows
Also, fix double counting in the uaf term: the uaf for each window
was multiplying the potential investments increase for the whole model.
But the uaf for each window should only multiply the potential
investments increase for that window.

If the investments resolution is larger than the window then it doesn't
matter I guess, but anyways, this seems more correct.
So the user can fix the investments during the first Benders iteration.
Resolve JuMP `Parameter` and `parameter_value` conflicts
…unctionality

Introduce equal_investments and min_max_entities_invested_available
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3429dee) 85.54% compared to head (239f358) 86.01%.
Report is 35 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   85.54%   86.01%   +0.46%     
==========================================
  Files         145      147       +2     
  Lines        3169     3267      +98     
==========================================
+ Hits         2711     2810      +99     
+ Misses        458      457       -1     
Files Coverage Δ
src/SpineOpt.jl 80.00% <ø> (ø)
src/constraints/constraint_connection_flow_lodf.jl 80.00% <ø> (ø)
...nt_investment_group_capacity_invested_available.jl 100.00% <100.00%> (ø)
...nt_investment_group_entities_invested_available.jl 100.00% <100.00%> (ø)
...s/constraint_investment_group_equal_investments.jl 100.00% <100.00%> (ø)
src/constraints/constraint_mp_any_invested_cuts.jl 100.00% <100.00%> (ø)
...aints/constraint_mp_min_res_gen_to_demand_ratio.jl 77.77% <ø> (ø)
src/constraints/constraint_unit_flow_op_bounds.jl 100.00% <ø> (ø)
src/constraints/constraint_units_available.jl 100.00% <ø> (ø)
src/data_structure/benders_data.jl 100.00% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada requested review from mihlema and tarskul October 2, 2023 07:57
@datejada datejada marked this pull request as ready for review October 2, 2023 07:57
@datejada datejada added the Zone: documentation Explanation of code, tutorials label Oct 2, 2023
@datejada
Copy link
Member Author

datejada commented Oct 2, 2023

@tarskul, this tutorial is ready for your review and approval
@mihlema I added you as a reviewer since you know more about the implementation of reserves in SpineOpt, so you might want to have a look, too.

@datejada
Copy link
Member Author

datejada commented Oct 2, 2023

I have rebased my branch to get the documentation passing the CI. So, now the PR passes all the tests ;)

Tars Verschelde and others added 4 commits October 9, 2023 15:40
Clarify how to include the upward reserve value in the SpineToolbox interface
Add to the introduction a short explanation of what the reserves are and why are important
@datejada
Copy link
Member Author

Deleting this PR since there was an error in the rebasing of the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zone: documentation Explanation of code, tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a tutorial to define reserves constraints
5 participants