Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): change job api group to batch #224

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

vdice
Copy link
Collaborator

@vdice vdice commented Sep 26, 2024

Describe your changes

  • Updates the job api group to batch for correct RBAC

Note: I'm not yet able to fully test via the make build deploy flow as RBAC issues remain. Next up are node permissions, which will require a rewrite of node_controller.go.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@github-actions github-actions bot added the kind/bug Something isn't working label Sep 26, 2024
@voigt voigt merged commit f1d9cd1 into spinkube:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants