feat(cdevents-webhooks) : Consume CDEvents webhook API implementation #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
Merged
mattgogerly
reviewed
Jun 16, 2023
echo-model/src/main/java/com/netflix/spinnaker/echo/model/trigger/CDEvent.java
Show resolved
Hide resolved
...n/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/CDEventsWebhookHandler.java
Outdated
Show resolved
Hide resolved
...n/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/CDEventsWebhookHandler.java
Outdated
Show resolved
Hide resolved
…/pipelinetriggers/eventhandlers/CDEventsWebhookHandler.java Co-authored-by: Matt <[email protected]>
…/pipelinetriggers/eventhandlers/CDEventsWebhookHandler.java Co-authored-by: Matt <[email protected]>
mattgogerly
approved these changes
Jun 23, 2023
added 2 commits
June 23, 2023 15:21
|
@rjalander do you mind running spotlessCheck and spotlessApply? I see the build is failing from those checks, but other than that, this LGTM 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to handle CDEvents webhook and run matching pipelines,
An endpoint "/webhooks/cdevents/{source}" created to receive the CDEvent and event will processed by CDEventsWebhookHandler.java to run the matching pipelines.
Note:
The implementation is as per the RFC design
https://github.com/spinnaker/governance/blob/master/rfc/cdevents-spinnaker.md#implementation-details
Dependent Spinnaker/gate PR - spinnaker/gate#1651
Dependent Spinnaker/deck PR - spinnaker/deck#9977